Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getrusage in mcache.c #441

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Fix getrusage in mcache.c #441

merged 3 commits into from
Sep 14, 2023

Conversation

derobins
Copy link
Member

@derobins derobins commented Sep 14, 2023 •
edited
Loading

getrusage(2) is used in the mcache statistics code, however:

  • Checked in cmake, but not added to h4config.h
  • Unchecked in Autotools
  • ifdef symbol in mcache.c was missing the H4_ prefix
  • Missing include
  • Format specifiers generate warnings
  • non-existent rusage struct member used

@derobins derobins added Component - Build CMake, Autotools Component - C Library Core C library issues Type - Bug Please report security issues to [email protected] instead of creating an issue on GitHub Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. labels Sep 14, 2023
@derobins derobins changed the title Fix getrusage configure and ifdefs Fix getrusage in mcache.c Sep 14, 2023
@derobins derobins merged commit 11277f1 into HDFGroup:master Sep 14, 2023
44 checks passed
@derobins derobins deleted the correct_getrusage branch March 3, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmribler bmribler bmribler approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@schwehr schwehr Awaiting requested review from schwehr schwehr is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Component - C Library Core C library issues Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Bug Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derobins @bmribler