Fix stack size warning in cdeflate.c #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts a giant stack array to a dynamically-allocated array. Also removes these internal symbols from cdeflate.h (which is public): * DEFLATE_BUF_SIZE * DEFLATE_TMP_BUF_SIZE
derobins
added
Component - C Library
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
derobins
commented
Sep 13, 2023
|
|
||
| /* Allocate a temporary buffer for decompression */ | ||
| if ((tmp_buf = (uint8 *)malloc(sizeof(uint8) * DEFLATE_TMP_BUF_SIZE)) == NULL) | ||
| HGOTO_ERROR(DFE_NOSPACE, FAIL); |
There was a problem hiding this comment.
This is the real change (everything else is tidying and adapting error handling to clean up memory)
derobins
commented
Sep 13, 2023
| @@ -27,10 +27,6 @@ | |||
| #include "zlib.h" | |||
| #undef zintf | |||
|
|
|||
| /* Define the [default] size of the buffer to interact with the file. */ | |||
| #define DEFLATE_BUF_SIZE 4096 | |||
| #define DEFLATE_TMP_BUF_SIZE 16384 | |||
There was a problem hiding this comment.
These should not be public
lrknox
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts a giant stack array to a dynamically-allocated array.
Also removes these internal symbols from cdeflate.h (which is public):