Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appdata: Improve appdata for AppStream 1.0 #120

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions data/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ appstream_file = i18n.merge_file(
install_dir: join_paths(get_option('datadir'), 'metainfo')
)

appstream_util = find_program('appstream-util', required: false)
if appstream_util.found()
test('Validate appstream file', appstream_util,
args: ['validate', appstream_file]
appstreamcli = find_program('appstreamcli', required: false)
if appstreamcli.found()
test('Validate appstream file',
appstreamcli,
args: ['validate', '--no-net', '--explain', appstream_file],
workdir: meson.current_build_dir()
)
endif

Expand Down
9 changes: 7 additions & 2 deletions data/org.gustavoperedo.FontDownloader.appdata.xml.in
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,17 @@
</releases>
<url type="homepage">https://github.com/GustavoPeredo/font-downloader</url>
<url type="bugtracker">https://github.com/GustavoPeredo/Font-Downloader/issues</url>
<url type="vcs-browser">https://github.com/GustavoPeredo/font-downloader</url>
<url type="translate">https://poeditor.com/join/project?hash=hfnXv8Iw4o</url>
<developer_name>Gustavo Peredo</developer_name>
<!-- developer_name tag deprecated with Appstream 1.0 -->
<developer_name translatable="no">Gustavo Peredo</developer_name>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong ID

<developer id="github.com">
<name translatable="no">Gustavo Peredo</name>
</developer>
<launchable type="desktop-id">org.gustavoperedo.FontDownloader.desktop</launchable>
<translation type="gettext">fontdownloader</translation>
<content_rating type="oars-1.1"/>
<custom>
<value key="Purism::form_factor">workstation</value>
<value key="Purism::form_factor">mobile</value>
</custom>
</component>
3 changes: 2 additions & 1 deletion org.gustavoperedo.FontDownloader.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"app-id" : "org.gustavoperedo.FontDownloader",
"runtime" : "org.gnome.Platform",
"runtime-version" : "44",
"runtime-version" : "45",
"sdk" : "org.gnome.Sdk",
"command" : "fontdownloader",
"finish-args" : [
Expand Down Expand Up @@ -50,6 +50,7 @@
"name" : "fontdownloader",
"builddir" : true,
"buildsystem" : "meson",
"run-tests" : true,
"sources" : [
{
"type" : "dir",
Expand Down