Skip to content

Commit

Permalink
appdata: Improve appdata for AppStream 1.0
Browse files Browse the repository at this point in the history
- Add the `<developer><name>` tag
- Mark the `<developer_name>` tag as deprecated
- Add vcs-browser URL
- Add translation tag
- Use appstreamcli to validate appdata
- Remove one of Purism tag to pass validation test
- Update Runtime version
- Activate meson tests on flatpak manifest
  • Loading branch information
yakushabb committed Dec 29, 2023
1 parent 3f2e198 commit cd197d1
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 7 deletions.
10 changes: 6 additions & 4 deletions data/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ appstream_file = i18n.merge_file(
install_dir: join_paths(get_option('datadir'), 'metainfo')
)

appstream_util = find_program('appstream-util', required: false)
if appstream_util.found()
test('Validate appstream file', appstream_util,
args: ['validate', appstream_file]
appstreamcli = find_program('appstreamcli', required: false)
if appstreamcli.found()
test('Validate appstream file',
appstreamcli,
args: ['validate', '--no-net', '--explain', appstream_file],
workdir: meson.current_build_dir()
)
endif

Expand Down
9 changes: 7 additions & 2 deletions data/org.gustavoperedo.FontDownloader.appdata.xml.in
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,17 @@
</releases>
<url type="homepage">https://github.com/GustavoPeredo/font-downloader</url>
<url type="bugtracker">https://github.com/GustavoPeredo/Font-Downloader/issues</url>
<url type="vcs-browser">https://github.com/GustavoPeredo/font-downloader</url>
<url type="translate">https://poeditor.com/join/project?hash=hfnXv8Iw4o</url>
<developer_name>Gustavo Peredo</developer_name>
<!-- developer_name tag deprecated with Appstream 1.0 -->
<developer_name translatable="no">Gustavo Peredo</developer_name>
<developer id="github.com">
<name translatable="no">Gustavo Peredo</name>
</developer>
<launchable type="desktop-id">org.gustavoperedo.FontDownloader.desktop</launchable>
<translation type="gettext">fontdownloader</translation>
<content_rating type="oars-1.1"/>
<custom>
<value key="Purism::form_factor">workstation</value>
<value key="Purism::form_factor">mobile</value>
</custom>
</component>
3 changes: 2 additions & 1 deletion org.gustavoperedo.FontDownloader.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"app-id" : "org.gustavoperedo.FontDownloader",
"runtime" : "org.gnome.Platform",
"runtime-version" : "44",
"runtime-version" : "45",
"sdk" : "org.gnome.Sdk",
"command" : "fontdownloader",
"finish-args" : [
Expand Down Expand Up @@ -50,6 +50,7 @@
"name" : "fontdownloader",
"builddir" : true,
"buildsystem" : "meson",
"run-tests" : true,
"sources" : [
{
"type" : "dir",
Expand Down

0 comments on commit cd197d1

Please sign in to comment.