chore: internal ChrootKvBackend refactor and test #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
tisonkun
commented
Nov 23, 2023
tisonkun
changed the title
Signed-off-by: tison <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2799 +/- ##
===========================================
- Coverage 84.68% 84.37% -0.31%
===========================================
Files 730 730
Lines 113711 113717 +6
===========================================
- Hits 96291 95949 -342
- Misses 17420 17768 +348 |
MichaelScofield
approved these changes
Nov 24, 2023
WenyXu
reviewed
Nov 24, 2023
WenyXu
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This follows up #2734 as @MichaelScofield suggested.
Checklist
Refer to a related PR or issue link (optional)