Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ChromeWindow
is misplaced in the following three cases.ChromeWindow
from the edge of the window's border.No-patched Patched
ChromeWindow
doesn't light up in case of an external window.ChromeWindow
's position isn't correct in case of external window.変更点
ChromeWindow
の位置がずれる不具合の修正。ChromeWindow
のコンテンツ表示を境界線の端から表示できるように変更しました。変更前 変更後
ChromeWindow
が光らない問題の修正。ChromeWindow
の位置がずれる問題の修正。すみません,#44 のデバッグが不十分でした。
補足 (Japanese only)
手元の Visual Studio 2015 でビルドしたものだと,外部ウィンドウを光らせる機能が正常に動作しない (外部ウィンドウからのイベントが飛んでこない) みたいです。
Visual Studio 2019 に移行するための PR を準備中なのですが,そちらの .NET Framework 4.5.2 の場合は動くのですが😢
原因がよくわかっていないため,外部ウィンドウ関連のみ Visual Studio 2019 でビルドしたものでテストしています。
また,.NET Core 3.1 では C++/CLI 関連のロードに失敗するようで,正常に動作しませんでした。