Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: http download retries too many times #849

Merged
merged 7 commits into from
Dec 24, 2024

Conversation

monkeyWie
Copy link
Member

No description provided.

@monkeyWie monkeyWie added the bug Something isn't working label Dec 22, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.43%. Comparing base (8b61343) to head (32e8745).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/test/httptest.go 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
+ Coverage   58.74%   59.43%   +0.68%     
==========================================
  Files          35       36       +1     
  Lines        4472     4506      +34     
==========================================
+ Hits         2627     2678      +51     
+ Misses       1572     1557      -15     
+ Partials      273      271       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monkeyWie monkeyWie changed the title fix: http response body read timeout handle fix: http download retries too many times Dec 24, 2024
@monkeyWie monkeyWie merged commit c970378 into main Dec 24, 2024
10 checks passed
@monkeyWie monkeyWie deleted the fix/http_response_body_timeout branch December 24, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant