Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark GCP Buildpacks builder as trusted in the examples #6284

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

briandealwis
Copy link
Member

Fixed #5971

Description
Mark our examples using the GCP Buildpacks builder (gcr.io/buildpacks/builder:v1) as a trusted builder. This setting causes the pack library to use the lifecycle that is in the image instead of trying to download and run the lifecycle-as-an-image.

(I'm unsure about retaining the digest in the buildpacks builder in the absence of tooling to automatically monitor and update digests, but left it in.)

This setting puts the user in charge and is simpler than having Skaffold maintain a list of trusted builders, or to see if it was possible to reuse the CNB project's method for trusted images.

@briandealwis briandealwis requested a review from a team as a code owner July 23, 2021 18:53
@briandealwis briandealwis requested a review from nkubala July 23, 2021 18:53
@google-cla google-cla bot added the cla: yes label Jul 23, 2021
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #6284 (b97f8bf) into main (cf4aab8) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6284      +/-   ##
==========================================
- Coverage   70.49%   70.48%   -0.01%     
==========================================
  Files         498      498              
  Lines       22560    22581      +21     
==========================================
+ Hits        15903    15916      +13     
- Misses       5627     5635       +8     
  Partials     1030     1030              
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 71.50% <0.00%> (-2.16%) ⬇️
pkg/skaffold/deploy/kubectl/kubectl.go 67.45% <0.00%> (-0.57%) ⬇️
pkg/skaffold/runner/v1/apply.go 0.00% <0.00%> (ø)
pkg/skaffold/runner/v1/deploy.go 74.28% <0.00%> (ø)
pkg/skaffold/kubernetes/manifest/images.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf4aab8...b97f8bf. Read the comment docs.

@nkubala nkubala enabled auto-merge (squash) July 28, 2021 20:06
@MarlonGamez
Copy link
Contributor

I think we'll need to rebase this to pull in #6311 for this to successfully build in kokoro @briandealwis

@nkubala nkubala merged commit 250acdf into GoogleContainerTools:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildpacks build fails on Apple M1: no matching manifest for linux/arm64/v8
3 participants