Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run gke mxla benchmark #536

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Only run gke mxla benchmark #536

merged 3 commits into from
Jan 10, 2025

Conversation

gobbleturk
Copy link
Collaborator

@gobbleturk gobbleturk commented Jan 10, 2025 •
edited
Loading

Description

Discussed with @tonyjohnchen, we should only run one MXLA benchmark dag, and we have chosen the more stable GKE one.

Tests

Ran in local dev environment here

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

tonyjohnchen
tonyjohnchen approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@tonyjohnchen tonyjohnchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gobbleturk gobbleturk changed the title Only run gke mxla Only run gke mxla benchmark Jan 10, 2025
@gobbleturk gobbleturk merged commit fbb96bf into master Jan 10, 2025
11 checks passed
@gobbleturk gobbleturk deleted the mattdavidow-only-gke-dcn-benchmark branch January 10, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyjohnchen tonyjohnchen tonyjohnchen approved these changes

@raymondzouu raymondzouu Awaiting requested review from raymondzouu raymondzouu is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner

Assignees

@tonyjohnchen tonyjohnchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gobbleturk @tonyjohnchen