Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Workload Stable Stack Images #398

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Refactoring Workload Stable Stack Images #398

merged 6 commits into from
Sep 23, 2024

Conversation

parambole
Copy link
Collaborator

Description

  • Refactored workloads on jax stable stack image Names to be in line with the standard
  • Refactored stable stack variable name for more clarity

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

jonb377
jonb377 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@jonb377 jonb377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RissyRan
RissyRan approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! Just have 1 note.

@parambole parambole merged commit 1815306 into master Sep 23, 2024
6 checks passed
@parambole parambole deleted the parambole/jax_stable_stack branch September 23, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RissyRan RissyRan RissyRan approved these changes

@jonb377 jonb377 jonb377 approved these changes

@will-cromar will-cromar Awaiting requested review from will-cromar

@allenwang28 allenwang28 Awaiting requested review from allenwang28 allenwang28 is a code owner

Assignees

@jonb377 jonb377

@RissyRan RissyRan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parambole @jonb377 @RissyRan