Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add copyright header to metadata.yaml.tmpl #12235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BBBmau
Copy link
Collaborator

@BBBmau BBBmau commented Nov 4, 2024

Resolves hashicorp/terraform-provider-google#20174

This is due to #12061 introducing new files that did not include the hashicorp copyright header. I also added in the autogenerate header.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@BBBmau BBBmau requested a review from roaks3 November 4, 2024 16:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 485 files changed, 8245 insertions(+))
google-beta provider: Diff ( 550 files changed, 9350 insertions(+))

@wyardley
Copy link
Contributor

wyardley commented Nov 4, 2024

Think these will probably need to be pound / hash symbol vs C / go style comments (# vs //)?

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 485 files changed, 8245 insertions(+))
google-beta provider: Diff ( 550 files changed, 9350 insertions(+))

@roaks3
Copy link
Contributor

roaks3 commented Nov 5, 2024

@BBBmau can you help me understand this a little better? Is it a hard requirement for all files to have the license header? And what about the generation type header? The generation type in particular seems a bit overkill to me considering these are only meant for housing a small amount of metadata.

Copy link

github-actions bot commented Nov 7, 2024

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting to hear back on whether we need this

Copy link

github-actions bot commented Dec 2, 2024

@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

Copy link

@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

Copy link

@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants