-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add copyright header to metadata.yaml.tmpl #12235
base: main
Are you sure you want to change the base?
Conversation
Think these will probably need to be pound / hash symbol vs C / go style comments ( |
@BBBmau can you help me understand this a little better? Is it a hard requirement for all files to have the license header? And what about the generation type header? The generation type in particular seems a bit overkill to me considering these are only meant for housing a small amount of metadata. |
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still waiting to hear back on whether we need this
@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
@BBBmau, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
Resolves hashicorp/terraform-provider-google#20174
This is due to #12061 introducing new files that did not include the hashicorp copyright header. I also added in the autogenerate header.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.