Remove default_from_api from liveness_probe field in Cloud Run v2 service

[yanweiguo]

Fix hashicorp/terraform-provider-google#17468.

Cloud Run doesn't set a default value for liveness probe. Marking liveness_probe field with default_from_api: true was a mistake.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: `liveness_probe` field in `google_cloud_run_v2_service` resource no longer has a default value from API side. Removing this field and applying the change will remove liveness probe from the Cloud Run service.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field template.containers.liveness_probe transitioned from optional+computed to optional google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 38
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages

• cloudrunv2

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccCloudRunV2Job_cloudrunv2JobFullUpdate
• TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample
• TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate
• TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate
• TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample

Get to know how VCR tests work

[hao-nan-li]

Quick note: for the Terraform-Google-Conversion failure, that exists in other 6.0 PRs as well, unrelated to your change.

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field template.containers.liveness_probe transitioned from optional+computed to optional google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 43
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• cloudrunv2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[hao-nan-li]

Could you do a rebase and let's run the tests again?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field template.containers.liveness_probe transitioned from optional+computed to optional google_cloud_run_v2_service - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 43
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• cloudrunv2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[hao-nan-li]

I'm a bit confused about where this error is coming from, looking at the current 6.0 branch, Terraform-Google-Conversion did not report anything. #11179.

One suggests to re-create a new branch from main and open another PR.

[yanweiguo]

One suggests to re-create a new branch from main and open another PR.

I think the branch should be based on FEATURE-BRANCH-major-release-6.0.0 instead of main per https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/#other-breaking-changes?

I think there would be unrelative changes if branching from main and merging into FEATURE-BRANCH-major-release-6.0.0.

[hao-nan-li]

One suggests to re-create a new branch from main and open another PR.

I think the branch should be based on FEATURE-BRANCH-major-release-6.0.0 instead of main per https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/#other-breaking-changes?

I think there would be unrelative changes if branching from main and merging into FEATURE-BRANCH-major-release-6.0.0.

Correct, the change should be based on FEATURE-BRANCH-major-release-6.0.0.

[yanweiguo]

oh, main branchwas synced intoFEATURE-BRANCH-major-release-6.0.0`

[yanweiguo]

Closed in favor of #11190