Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util to consume daat from fhirstore via BQ #572

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Conversation

surjits254
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@devanshmodi devanshmodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did initial review except for 2 comments everything LGTM.

utilities/consume/dataflow_fhirstore_bq_consume/README.md Outdated Show resolved Hide resolved
utilities/consume/dataflow_fhirstore_bq_consume/README.md Outdated Show resolved Hide resolved
@devanshmodi devanshmodi self-requested a review February 29, 2024 22:22
Copy link
Collaborator

@devanshmodi devanshmodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved LGTM

Copy link
Collaborator

@svetakvsundhar svetakvsundhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM (with a minor nit)

utilities/consume/dataflow_fhirstore_bq_consume/main.py Outdated Show resolved Hide resolved
@surjits254 surjits254 merged commit a2dc56f into master Feb 29, 2024
6 checks passed
@surjits254 surjits254 deleted the fhir_bq_consume_util branch February 29, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants