Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pure php grpc #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

pure php grpc #1

wants to merge 3 commits into from

Conversation

ZhouyihaiDing
Copy link
Contributor

@ZhouyihaiDing ZhouyihaiDing commented Jan 4, 2018

Try to implement gRPC with pure PHP.
Use curl to send and receive rpc with http2_prior_knowledge.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

<?php
require dirname(__FILE__).'/vendor/autoload.php';

$client = new \Grpc\Gateway\Testing\EchoServiceClient('localhost:9091', []);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we re-use the plugin from grpc-php(C-core)? Generated Client doesn't have the default value for it. Something like credentials must be set at the second parameter.

{
$active = null;
while (!$this->stream_end || $this->received_data->valid()) {
if($this->received_data->valid()){
Copy link
Contributor Author

@ZhouyihaiDing ZhouyihaiDing Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if => while
or add
if($active<=0) break; to line 137 because curl_multi_select is blocked until activity or timeout. If there are no more activity with valid $this->received_data, every yield will wait for a time-out time.

@@ -0,0 +1,13 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's skip the example code for now. As we probably want to use the same proto defined in grpc report instead of using echo.prot here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All example related files are removed.

@@ -0,0 +1,24 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to /src/Grpc folder. The dir structure would be something like:
/src
/test
/doc
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants