fix: Ensure application files are readable by non-root users #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourgeoisor
reviewed
Aug 22, 2024
| @@ -37,4 +37,7 @@ ENV LOG_LEVEL info | |||
| # Add application code. | |||
| COPY . . | |||
|
|
|||
| # Ensure files are readable for non-root users | |||
| RUN chmod a+r * | |||
There was a problem hiding this comment.
This defeats the purpose of running in non-root, since it gives gives access to all files to non-root, potentially creating security issues.
There was a problem hiding this comment.
Only to the application code and config files in /app -- I can make this more explicit if helpful. Another option would be to chown these to the user/group the pod is configured to run as.
bourgeoisor
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2193
Background
The following services were failing to start (state of
CrashLoopBackOff), because of missing file permissions in/appfor non-root users:contactsuserservicefrontendChange Summary
Update Dockerfile to modify permissions of files in
/appso they are readable by all users.Related PRs or Issues
#2193