Check if using t.Cleanup fixes unit test failures on win/mac

GoogleCloudPlatform · Oct 1, 2024 · ff335ac · ff335ac
1 parent f96409c
commit ff335ac
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/metrics_test.go b/metrics_test.go
@@ -181,7 +181,7 @@ func TestDialerWithMetrics(t *testing.T) {
 	if err != nil {
 		t.Fatalf("expected Dial to succeed, but got error: %v", err)
 	}
-	defer conn.Close()
+	t.Cleanup(func() { conn.Close() })
 	// dial a second time to ensure the counter is working
 	conn2, err := d.Dial(ctx, testInstanceURI)
 	if err != nil {
@@ -203,7 +203,7 @@ func TestDialerWithMetrics(t *testing.T) {
 	if err != nil {
 		t.Fatalf("conn.Write failed: %v", err)
 	}
-	defer conn2.Close()
+	t.Cleanup(func() { conn2.Close() })
 	// dial a bogus instance
 	_, err = d.Dial(ctx,
 		"projects/my-project/locations/my-region/clusters/"+