Skip to content
YuriyZ edited this page May 3, 2019 · 1 revision

There are a few important things

  • open PR with the fix to particular ticket
  • do not perform redundant re-formatting. Just change exact lines that are required by fix
  • in PR link ticket that it fixes as well as short description (usually copy of what you see in title of the ticket).
  • make sure that tests are passed (jenkins: https://ox.gluu.org/jenkins).
  • if PR changes oxd API then it must be reflected in swagger spec! It's critical since customers are generating oxd clients from swagger spec.