Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Anno's 1800 broken multiplayer, allows players to join lobbies … #88

Closed
wants to merge 1 commit into from

Conversation

Knogle
Copy link

@Knogle Knogle commented Mar 8, 2023

…and play now.

Due to missing case handling for ECDH_P384 during the joining handshakes for multiplayer it's not possible to join a friend's game without this fix. It's interesting for Proton due to Ubisoft games being available on Steam again, but may also be of interest for wine-ge-custom.
This fix has been comitted already, ValveSoftware/wine#173 but may take months or years to go upstream.

@Sulavius
Copy link

Sulavius commented Mar 9, 2023

I have tested your patch @Knogle, I can't get multiplayer with it to work. I have an Open NAT, and it is not possible to create a lobby with my friend on Windows. Error LR05

@Knogle
Copy link
Author

Knogle commented Mar 9, 2023

Hmm. Maybe this helps you. It's the same code, but stripped by some redundant stuff.
ValveSoftware/wine#181

@Knogle
Copy link
Author

Knogle commented Mar 9, 2023

I have tested your patch @Knogle, I can't get multiplayer with it to work. I have an Open NAT, and it is not possible to create a lobby with my friend on Windows. Error LR05

I've confirmed your issue. I have to figure out what's wrong. Seems like the patch is getting overriden by something else. Could you try building it from https://github.com/ValveSoftware/Proton instead? It works flawlessy for ma and others. ValveSoftware/wine#181 I think we have to figure out first what is going wrong here.

@lucabadin
Copy link

@Knogle, heads up that case ALG_ID_ECDH_P384 should go together with case ALG_ID_ECDSA_P384 a couple of lines below. This was also present in ValveSoftware/wine#173 but is fixed in ValveSoftware/wine#181.

I'm guessing that's the issue @Sulavius had as well, because upon compiling Proton with the correct fix everything works as it should.

@Sulavius
Copy link

Sulavius commented Mar 9, 2023

I have built https://github.com/ValveSoftware/Proton with the pull request ValveSoftware/wine#181 now the lobby creation works. Thanks to all involved in the troubleshooting.

@Etaash-mathamsetty
Copy link

Etaash-mathamsetty commented Mar 9, 2023

but may take months or years to go upstream.

This fix is a good temporary fix, but it will not be needed with proton 8 and future versions (seems to be fixed in upstream wine, commit 5253c8d77e8e7dc5770981e97e67348f393b99b9)
maybe we could just use the upstream fix
just letting you know

@GloriousEggroll
Copy link
Owner

included the fix from ValveSoftware/wine#181 in 7-51. Should be able to remove the patch when proton wine 8 rebase is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants