Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1879 Include fullscreen button in embed pages #1880

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

allyoucanmap
Copy link
Collaborator

@allyoucanmap allyoucanmap commented Oct 10, 2024

This PR improves the share embed section to include the fullscreen plugin, the embed share link has been converted from url to iframe snippet.

Now when an embed page uses the allowFullscreen=true query param the fullscreen button will be added in a menu to the bottom of the iframe.

In the screenshot on the left embed whithout fullscreen and on the right with fullscreen
image

New embed section in share panel
image

@allyoucanmap allyoucanmap added this to the 4.4.1 milestone Oct 10, 2024
@allyoucanmap allyoucanmap self-assigned this Oct 10, 2024
@allyoucanmap allyoucanmap added the enhancement New feature or request label Oct 10, 2024
@allyoucanmap allyoucanmap linked an issue Oct 10, 2024 that may be closed by this pull request
@allyoucanmap allyoucanmap requested a review from giohappy October 10, 2024 08:28
@giohappy giohappy merged commit 5821ad2 into GeoNode:master Oct 10, 2024
4 checks passed
Copy link

The backport to 4.4.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4.x 4.4.x
# Navigate to the new working tree
cd .worktrees/backport-4.4.x
# Create a new branch
git switch --create backport-1880-to-4.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5821ad2a49cdfaa73054d53251d3f9f1027e1129
# Push it to GitHub
git push --set-upstream origin backport-1880-to-4.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4.x

Then, create a pull request where the base branch is 4.4.x and the compare/head branch is backport-1880-to-4.4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include fullscreen button in embed pages
2 participants