-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and target frameworks and fix build warnings #27
Conversation
Hi ! Thanks a lot for your contribution. Will review and ask a review from @janusw (I have to add it here also) who did so much lately for the main repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything wrong with this, except that probably the GHA hooks need to be updated to deal with .NET 8 as well. Maybe someone can approve the workflows to run, so that we can see them fail? 😆
Good point, I also updated the GitHub actions and dropped the EOL .NET versions from CI. |
👍 Now we only need someone to approve the workflows so that they will actually run. @xfischer Can you do that? |
Alright, so the build job runs fine, but the benchmarking job fails. That one also needs to be adjusted: |
Benchmarks should hopefully be fixed now, but I guess the workflow needs another approval. 😄 I removed net6.0 from the benchmark project since .NET 6 is EOL next month anyway. |
Since I'm a maintainer, I can do that now. 💪 (thanks, @xfischer !) |
Alright, all the CI jobs run fine by now and the PR was approved already, so I'll just merge it ... |
Starting with .NET 9, NuGet Audit will transitively scan for CVEs, so consuming applications will get a warning about System.Text.Json:
#24 already optimized this to only affect .NET Framework (but it's still not released).
This updates all dependencies (except Nunit 4 which has a lot of breaking changes) and cleans up some build warnings:
Microsoft.CodeAnalysis.NetAnalyzers
because it's part of the SDK since .NET 5