Figure.plot/Figure.plot3d: Improve the check of the "style" parameter for "v" or "V" #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
needs review
seisman
changed the title
seisman
added
final review call
weiji14
approved these changes
Nov 11, 2024
seisman
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GMT, when both symbol and size are read from files, the
-Soption can be specified without arguments. Thus,style=""orstyle=Trueshould be valid.However, currently we check
kwargs.get("S") is not None and kwargs["S"][0] in "vV"which doesn't make sense ifstyleis not a string or is an empty string.This PR fixes the checking of the
styleparameter.Strictly speaking, it's a bug, but I don't want to add one more test for such a minor change. So mark it as "maintenance" and "skip-changelog".