Improve the workarounds for handling pandas nullable dtypes in pandas<=2.1 #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
bug
Comment on lines
+165
to
+171
| # pandas nullable dtypes and pyarrow types were converted to np.object_ dtype | ||
| # before, and are converted to suitable numpy dtypes since pandas 2.2. | ||
| # Refer to the following link for details: | ||
| # https://pandas.pydata.org/docs/whatsnew/v2.2.0.html#to-numpy-for-numpy-nullable-and-arrow-types-converts-to-suitable-numpy-dtype | ||
| # Here are the workarounds for pandas < 2.2. | ||
| # Following SPEC 0, pandas 2.1 should be dropped in 2025 Q3, so it's likely we can | ||
| # remove the workaround in PyGMT v0.17.0. |
There was a problem hiding this comment.
Suggested change
| # pandas nullable dtypes and pyarrow types were converted to np.object_ dtype | |
| # before, and are converted to suitable numpy dtypes since pandas 2.2. | |
| # Refer to the following link for details: | |
| # https://pandas.pydata.org/docs/whatsnew/v2.2.0.html#to-numpy-for-numpy-nullable-and-arrow-types-converts-to-suitable-numpy-dtype | |
| # Here are the workarounds for pandas < 2.2. | |
| # Following SPEC 0, pandas 2.1 should be dropped in 2025 Q3, so it's likely we can | |
| # remove the workaround in PyGMT v0.17.0. | |
| # pandas nullable dtypes and PyArrow types were converted to np.object_ dtype | |
| # before, and are converted to suitable NumPy dtypes since pandas 2.2. | |
| # Refer to the following link for details: | |
| # https://pandas.pydata.org/docs/whatsnew/v2.2.0.html#to-numpy-for-numpy-nullable-and-arrow-types-converts-to-suitable-numpy-dtype | |
| # Here are the workarounds for pandas < 2.2. | |
| # Following SPEC 0, pandas 2.1 should be dropped in 2025 Q3, so it's likely we can | |
| # remove the workaround in PyGMT v0.17.0. |
seisman
added
needs review
|
Please review the changes in #3584 first. I'll cherry-pick changes in that PR to this PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR is cherry-picked from #3584. See that PR for context. More tests will be added in that PR too.
This PR is an improved version of PR #3505.
Labeling this PR as "bug" and we will merge the two entries for PR #3505 and this PR when we drafting the release changelog.