Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: DOC: Add advanced tutorial "Creating legends" #3594

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Nov 6, 2024

Description of proposed changes

This PR addes the advanced tutorial "Creating legends":

  • Create a auto-legend: label parameter of plotting methods
  • Adjust position: position parameter, +w, +o, +j
  • Add box: +p, +g
  • Create manuall legend: spec parameter, io.StringIO object

Fixes #3444

Preview: https://pygmt-dev--3594.org.readthedocs.build/en/3594/tutorials/advanced/legends.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation enhancement Improving an existing feature labels Nov 6, 2024
@yvonnefroehlich yvonnefroehlich added this to the 0.14.0 milestone Nov 6, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this Nov 6, 2024
@yvonnefroehlich yvonnefroehlich marked this pull request as draft November 6, 2024 12:03
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
@yvonnefroehlich yvonnefroehlich changed the title POC: WIP: DOC: Add advanced tutorial "Legend" WIP: DOC: Add advanced tutorial "Legends" Nov 11, 2024
@yvonnefroehlich yvonnefroehlich changed the title WIP: DOC: Add advanced tutorial "Legends" WIP: DOC: Add advanced tutorial "Creating legends" Nov 11, 2024
# Create an auto-legend
# ---------------------
#
# For auto-legends, the ``label`` parameter of :meth:`pygmt.Figure.plot` has to be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other plotting methods (e.g., plot3d/histogram) also have the label parameter, so better to be general here and use Figure.plot as an example.

Copy link
Member Author

@yvonnefroehlich yvonnefroehlich Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the explanation text in commit 49773b4. Now it's mention that multiple methods have the (legend-related) label parameter and we use Figure.plot examplarly in this tutorial.

fig = pygmt.Figure()
fig.basemap(region=[-5, 5, -5, 5], projection="X5c", frame=True)

fig.plot(x=0, y=0, style="c0.25c", fill="orange", label="orange circle")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to call Figure.plot twice with different labels, so that users can know the default layout for legend entries.

Copy link
Member Author

@yvonnefroehlich yvonnefroehlich Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Now, three symbols are plotted to show that by default a one-column legend is created and the order of the symbols is given by the plotting order; see commit a47babf. Or did you mean something different?

examples/tutorials/advanced/legends.py Outdated Show resolved Hide resolved
# possible to provide this information as an :class:`io.StringIO` object. Both, the
# ASCII file or the :class:`io.StringIO` object are passed to the ``spec`` parameter
# of :meth:`pygmt.Figure.legend`.
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this part needs some work on the documentation side. Will do this in the next days 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a gallery example for Figure.legend with StringIO input
2 participants