Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing pd.Int32Dtype/pd.Int64Dtype for geopandas integration #2839

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 30, 2023

Description of proposed changes

geopandas v0.14.0 was released on Sep 15, 2023.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Nov 30, 2023
@seisman seisman added this to the 0.11.0 milestone Nov 30, 2023
@seisman seisman requested a review from weiji14 November 30, 2023 09:08
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just cross-referencing #2592 (comment) where these lines were originally added.

Btw, do we still want to handle the casting of numbers in the int32 < x <= int64 range as mentioned at #2592 (comment)?

@seisman seisman merged commit d8752d5 into main Dec 1, 2023
12 of 13 checks passed
@seisman seisman deleted the geopandas-tests branch December 1, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants