Use Okina in Hawaiʻi and ā with macron in Mānoa #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing apostrophe with Okina letter in a few places. Approximating the Okina letter with a ` (octal code 140) for the roads gallery example.
weiji14
added
documentation
weiji14
commented
Aug 26, 2023
| @@ -18,7 +18,7 @@ The following people have contributed code and/or documentation to the project | |||
| * [Leonardo Uieda](http://www.leouieda.com/) | [0000-0001-6123-9515](https://orcid.org/0000-0001-6123-9515) | University of Liverpool, United Kingdom | |||
| * [Liam Toney](https://liam.earth/) | [0000-0003-0167-9433](https://orcid.org/0000-0003-0167-9433) | University of Alaska Fairbanks, USA | |||
| * [Malte Ziebarth](https://github.com/mjziebarth) | [0000-0002-5190-4478](https://orcid.org/0000-0002-5190-4478) | GFZ German Research Centre for Geosciences, Germany | |||
| * [Max Jones](https://github.com/maxrjones) | [0000-0003-0180-8928](https://orcid.org/0000-0003-0180-8928) | University of Hawai'i at Mānoa, USA | |||
| * [Max Jones](https://github.com/maxrjones) | [0000-0003-0180-8928](https://orcid.org/0000-0003-0180-8928) | University of Hawaiʻi at Mānoa, USA | |||
There was a problem hiding this comment.
Hi @maxrjones, just checking if you're still happy to keep your affiliation with UoH?
examples/gallery/lines/roads.py
Outdated
| region = [-158.3, -157.6, 21.2, 21.75] # xmin, xmax, ymin, ymax | ||
|
|
||
| title = r"Main roads of O\047ahu (Hawai\047i)" # \047 is octal code for ' | ||
| title = r"Main roads of O\140ahu (Hawai\140i)" # \140 is octal code for `, approximating the Okina ʻ |
There was a problem hiding this comment.
Technically \140 is a backtick ` (U+0060), but this is the closest approximation I know to the Okina letter ʻ (U+02BB) as mentioned at https://github.com/GenericMappingTools/pygmt/pull/2641/files#r1306294445. Anyone who knows how to plot the Okina properly is welcome to chime in!
seisman
reviewed
Aug 26, 2023
Co-authored-by: Dongdong Tian <[email protected]>
michaelgrund
approved these changes
Aug 26, 2023
yvonnefroehlich
approved these changes
Aug 26, 2023
Co-Authored-By: Yvonne Fröhlich <[email protected]>
|
Will leave this open for another day (until US Eastern time evening) before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Replacing apostrophe with Okina letter in a few places. Approximating the Okina letter with a ` (octal code 140) for the roads gallery example.
Preview at https://pygmt-dev--2644.org.readthedocs.build/en/2644/gallery/lines/roads.html
Reference:
Fixes #1474 (comment)
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version