handle div by zero edge case in maxRedeem #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check in the
maxRedeem
function to return zero if the prize vault is in a lossy state, but there are absolutely no assets left. This is an extremely unlikely scenario since it requires the yield vault to have lost all funds, but at least the hypothetical prize vault depositors can be soothed by the knowledge that the prize vault is still 4626 compliant after a yield vault's unfortunate demise.