feat: emergency liquidator draft #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmikko
reviewed
May 31, 2024
contracts/EmergencyLiquidator.sol
Outdated
| /// @dev Returns whether the msg.sender can liquidate in lieu of policy | ||
| function _isPolicyWaived(address account) internal view returns (bool) { | ||
| return isWhitelisted[account] | ||
| && block.timestamp > lastWhitelistedPolicyWaivedTimestamp + whitelistedPolicyWaiveDuration; |
There was a problem hiding this comment.
It seems that these 2 vars could be combined into one allowedPublicLiquidationsTill, which could be set as block.timestamp + duration
| /// whitelisted addresses | ||
| bool public whitelistedOnlyWithLoss; | ||
| /// @notice Map to substitute prices of tokens with other tokens, for policy checks | ||
| mapping(address => address) public priceAlias; |
There was a problem hiding this comment.
No method to get all set aliases in a call
contracts/EmergencyLiquidator.sol
Outdated
| @@ -46,13 +57,21 @@ contract EmergencyLiquidator is ACLNonReentrantTrait, IEmergencyLiquidatorExcept | |||
| /// @notice Whether the address is a trusted account capable of doing whitelist-only actions | |||
| mapping(address => bool) public isWhitelisted; | |||
There was a problem hiding this comment.
It's better to use EnumerableSet.Address to get all whitelisted liquidators
contracts/EmergencyLiquidator.sol
Outdated
| address creditManager, | ||
| address creditAccount, | ||
| MultiCall[] calldata calls | ||
| ) external whitelistedOnly { |
There was a problem hiding this comment.
Porbably, it's good to make the contract pausable to block all liquidations if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.