Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added jwt, private key on sdk creation #69

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

Siddharth9890
Copy link
Collaborator

No description provided.

@Siddharth9890 Siddharth9890 added the enhancement New feature or request label Oct 1, 2024
@Siddharth9890 Siddharth9890 self-assigned this Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.02%. Comparing base (ac4330b) to head (6d0df4d).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/helpers/helper.ts 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #69      +/-   ##
===========================================
- Coverage    90.95%   90.02%   -0.94%     
===========================================
  Files           15       16       +1     
  Lines          376      391      +15     
  Branches        70       72       +2     
===========================================
+ Hits           342      352      +10     
- Misses          34       38       +4     
- Partials         0        1       +1     
Flag Coverage Δ
90.02% <91.48%> (-0.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@R11manish R11manish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Siddharth9890 Siddharth9890 merged commit 34f2ab6 into develop Oct 2, 2024
4 of 5 checks passed
@Siddharth9890 Siddharth9890 deleted the feat/make-auth-class-public branch October 2, 2024 04:51
@Siddharth9890 Siddharth9890 restored the feat/make-auth-class-public branch October 2, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants