Data model , proof and request #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siddharth9890
requested changes
Dec 5, 2023
| * call. | ||
| */ | ||
|
|
||
| async createProof(inputVariables?: createProof_mutationMutationVariables) { |
There was a problem hiding this comment.
it should not be optional i guess
There was a problem hiding this comment.
that is already optional , as u can see ?
| }); | ||
|
|
||
| expect(createDataModel?.title).toEqual('Test'); | ||
| }, 40000); |
There was a problem hiding this comment.
the timeout should be a variable which is constant
There was a problem hiding this comment.
nopes , every test cases takes differenet amount of time , so we can't store into a variable.
| const { issuersByDataModel } = await api.dataModel.getIssuersByDataModel( | ||
| process.env.DATAMODEL_ID as string, | ||
| ); | ||
|
|
| await api.dataModel.getTotalofIssuersByDataModel( | ||
| process.env.DATAMODEL_ID as string, | ||
| ); | ||
|
|
| const { issuersByDataModelCount } = | ||
| await api.dataModel.getIssuersByDataModelCount( | ||
| process.env.DATAMODEL_ID as string, | ||
| ); |
|
|
||
| describe('proofs related test', () => { | ||
| it('create proof', async () => { | ||
| const {} = await api.proof.createProof({}); |
| return await this.sdk.createDataModel_mutation({ | ||
| input: createModelInput, | ||
| }); | ||
| } catch (error: any) { |
There was a problem hiding this comment.
remove :any part from all catch blocks just to maintain consistency
| * @returns The `getDataModelsCount` function is returning the result of the `dataModelsCount_query` | ||
| * method call, which is a promise. | ||
| */ | ||
|
|
There was a problem hiding this comment.
run pnpm format missing lines in test files as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with test cases