-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow never-type goals in lockout #13
base: main
Are you sure you want to change the base?
Allow never-type goals in lockout #13
Conversation
c22c5bd
to
ac58085
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just small things. However, I have another issue I'd like to bring up. If the last goal is a never goal, nothing special is done. It should be made such that the game immediately ends in this case. The logic for immediately ending a lockout is already there, so you just need to make it run that in this case.
common/src/main/java/io/github/gaming32/bingo/client/BingoClient.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/gaming32/bingo/client/BingoClient.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/gaming32/bingo/game/BingoGame.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/gaming32/bingo/game/BingoGameMode.java
Outdated
Show resolved
Hide resolved
common/src/main/java/io/github/gaming32/bingo/game/BingoGameMode.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Still needs a big test, obviously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I forgot. There still needs to be a check for if all the remaining goals are never goals, and triggering an immediate end if so.
Would it be an option to make goals that will be skipped if nothing else is left another special tag? Some never goals would be okay at the end of the game, for example a game tied on 12-12 with "never die" left (if you're playing with a player tracker and are able to find and attack the other team). |
During playtesting today we also found out that a negative goal being awarded doesn't trigger the check for game winning so I'll work on that too. |
fbdd59e
to
e15f8db
Compare
I think this works, but I'm not sure if the stalemate tag could cause confusion, being only relevant for lockout gamemode. |
I'd prefer if the |
After transitioning from a different mod for lockout, we wanted to be able to reimplement some of the goals in a datapack, especially negative goals that prohibit you from doing something in the game.
This code probably isn't great, but it adds a possible implementation for that. The logic is that initially every team is eligible to get the goal, shown by a split background colour. Once all but one team have lost the condition, that last team gets the point.
This probably shouldn't be active by default because it requires some consideration for goals. The goals need to either be easy to get accidentally, like "never take fall damage" or be possible for other teams to enforce, like "never die" (especially when playing with a player tracker). I added the start parameter
--allow-never-goals-in-lockout
for that.