Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to coveralls github action instead of running commands manually #2480

Open
peace-maker opened this issue Oct 2, 2024 · 0 comments
Open

Switch to coveralls github action instead of running commands manually #2480

peace-maker opened this issue Oct 2, 2024 · 0 comments
Labels
feature

Comments

@peace-maker
Copy link
Member

We should consider using https://github.com/marketplace/actions/coveralls-github-action#complete-parallel-job-example instead of our own solution. That would have avoided the hidden-files problem when combining the coverage data manually.
peace-maker added a commit to peace-maker/pwntools that referenced this issue Dec 18, 2024
@peace-maker
Disable uploading coverage on Windows
5ad4723 
The handrolled coveralls upload cannot handle mixed operating systems.

Refs Gallopsled#2480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peace-maker