Camera guides for Gaffer 1.5+ #6136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added preliminary support for camera guides (action safe, title safe and rule of thirds).
Fixed way overcomplicated menu item code.
Whitespace fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated this PR to work with Gaffer 1.5+, squashed the commits so it's cleaner and closed the old one. All seems to be working well in 1.5.0.1. One potential issue I notice is that adding or removing a guide triggers a fresh render when using Cycles. Not so bad when you've got a simple scene, but could be a pain if you had to restart a heavier render.