Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StandardNodeGadget : Persistent nodule labels #6135

Open
wants to merge 1 commit into
base: 1.5_maintenance
Choose a base branch
from

Conversation

ericmehl
Copy link
Collaborator

@ericmehl ericmehl commented Nov 6, 2024

This adds the ability to add metadata to a node to either always show or always hide the node's nodule labels. If there's no metadata entry, the current behavior prevails and the labels are shown on hover.

I'm handling input and output plugs independently here - it seems like there could be cases where you'd want the labels on input plugs but not outputs (like a shader) or on output plugs but not inputs (like query nodes). It does make it a bit more verbose so happy to discuss if it would be better to settle on something simpler.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@ericmehl
Copy link
Collaborator Author

ericmehl commented Nov 7, 2024

Just noting I pushed an amendment that fixes the merge conflict, and makes a minor cosmetic change to a local variable name for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

1 participant