DeletePoints : Add support for id lists. #6105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldresser-ie
force-pushed
the
deletePointsExtra
branch
from
bdcbf1b
to
0b26a3a
Compare
johnhaddon
reviewed
Oct 25, 2024
danieldresser-ie
force-pushed
the
deletePointsExtra
branch
from
0b26a3a
to
803b7b1
Compare
|
Added a fix commit addressing feedback. I think the only remaining question is the naming of "idList" vs "idListVariable". |
danieldresser-ie
force-pushed
the
deletePointsExtra
branch
from
803b7b1
to
138c97d
Compare
|
I think this is ready to merge, pending a squash after review, and any comments from @murraystevenson on the naming of "idListVariable". |
johnhaddon
force-pushed
the
deletePointsExtra
branch
from
138c97d
to
72f986a
Compare
|
Thanks Daniel! I've squashed the fix in, added the DeletePoints change to Changes.md, and am merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using lists of ids ( like the "inactiveIds" primvar coming from USD instancers ) to delete points.