Merge pull request #5247 from johnhaddon/referenceFrameActivator

ConstraintUI : Add activator for `referenceFrame` plug
GafferHQ · Apr 12, 2023 · 933b0ed · 933b0ed
2 parents ccc8fea + 0a93ae5
commit 933b0ed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/Changes.md b/Changes.md
@@ -14,6 +14,7 @@ Improvements
 - ArnoldAttributes : Added `shadowAutoBumpVisibility` plug, since Arnold 7.2.1.0 now correctly implements this feature.
 - Shader : Added support for shading input connections to splines. After double clicking on a spline to open the editor, you may select a control point, and then drag an input to the value control. Works in GafferImage, GafferObject and Arnold. Supports a max of 32 values in the spline.
 - FloatSpline and ColorSpline OSL shaders : Added a `direction` parameter, with options of `U`, `V`, `Diagonal`, `Radial` and `Custom`.
+- Constraint : Disabled the `referenceFrame` plug in the NodeEditor when `keepReferencePosition` is off.
 
 Fixes
 -----

diff --git a/python/GafferSceneUI/ConstraintUI.py b/python/GafferSceneUI/ConstraintUI.py
@@ -56,6 +56,7 @@
 	"layout:activator:targetModeIsUV", lambda node : node["targetMode"].getValue() == GafferScene.Constraint.TargetMode.UV,
 	"layout:activator:targetModeIsVertex", lambda node : node["targetMode"].getValue() == GafferScene.Constraint.TargetMode.Vertex,
 	"layout:activator:keepReferencePositionIsOff", lambda node : not node["keepReferencePosition"].getValue(),
+	"layout:activator:keepReferencePositionIsOn", lambda node : node["keepReferencePosition"].getValue(),
 
 	plugs = {
 
@@ -172,6 +173,8 @@
 			is adjusted so that the original position at this frame is maintained.
 			""",
 
+			"layout:activator", "keepReferencePositionIsOn",
+
 		],
 
 	},