Blacklist Thaumcraft clusters + made the file more readable #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: 2 uncommitted changes |
|
This is still waiting on a review. |
Alastors
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
I know I'm no longer on the dev team so my opinion means nothing, however:
Looked through it, looks fine, looks a bit over engineered but the system already was so that's no fault of your own, fuckin Bart and all that.
Dunno why someone else hasn't already given you a rubber stamp already tho
|
@Dream-Master or whatever |
chochem
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've blacklisted the vanilla Thaumcraft Clusters so that WG doesn't create duplicates of them, but that means they need some special attention to implement the additional recipes that exist.
The Cinnabar is almost working as intended.
All this just to:
fixes #17825
This was complicated to fix Bart...
This is ready for review now.