Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steam machine hull assembler recipes #1052

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Dioxop
Copy link
Contributor

@Dioxop Dioxop commented Oct 21, 2024

- Added Bronze Hull Assembler Recipe
- Added Bricked Bronze Hull Assembler Recipe
- Added Steel Hull Assembler Recipe
- Added Bricked Wrought Iron Hull Assembler Recipe
@Dream-Master Dream-Master requested a review from a team October 21, 2024 19:31
@Dream-Master
Copy link
Member

@Dioxop you must use the right item via itemlist not via Moditem

Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those recipes just look incorrect, not sure what happened here. for example why does a standard 8 plate recipe suddenly need a fluid?
Also the likelihood that these are causing conflicts is like 90%+.

@Dioxop
Copy link
Contributor Author

Dioxop commented Oct 21, 2024

I added a fluid because the steel machine hull recipe would cause a conflict otherwise and the other machine hulls also use fluids

@LazyFleshWasTaken
Copy link

I added a fluid because the steel machine hull recipe would cause a conflict otherwise and the other machine hulls also use fluids

You could use a different circuit then

@chochem
Copy link
Member

chochem commented Oct 21, 2024

it didnt work, they are still conflicting lol.

@Dioxop
Copy link
Contributor Author

Dioxop commented Oct 21, 2024

@chochem how? I don't see any recipe that even uses bronze or steel plates with refined glue

@chochem
Copy link
Member

chochem commented Oct 21, 2024

so you are looking for the wrong thing. that explains why you didnt catch conflicts. Well these recipes need to be changed fundamentally anyway.

@Dioxop
Copy link
Contributor Author

Dioxop commented Oct 21, 2024

lol, okay. do you have a recommendation? i would have used an integrated circuit (8) if the steel hull didn't conflict with the lv machine casing

@LazyFleshWasTaken
Copy link

I'd reocmmend eitehr c6 or c16, both should have no conflict with bronze or steel plates.

@chochem
Copy link
Member

chochem commented Oct 21, 2024

for that one sure. but still need the others fixed

PS: totally didnt delete posts where I said stupid stuff because I am blind

* Changed the ModItem method to the itemlist method
* Changed the new steam machine hull assembler recipes
* Changed the Casing_BronzePlatedBricks assembler recipe to use a
   16 integrated circuit
@Dioxop
Copy link
Contributor Author

Dioxop commented Oct 21, 2024

Okay, I implemented the recommended changes

.itemOutputs(ItemList.Hull_Bronze.get(1)).duration(2 * SECONDS + 10).eut(TierEU.RECIPE_LV)
.addTo(assemblerRecipes);

// Bricked Bronze Hull
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with the Bronze Hull above if you are making a lot of them, since the only thing differentiating them is the addition of Bricks in this Recipe. Having them both on circuit 6 shouldn’t be done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the exact rules for a new recipe? Does it need to have at least two different items or a different circuit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any combinations of items (regardless of their amount) in a recipe can make another recipe, that's a conflict. If there's a conflict the recipe has to be changed to fix it, though this usually means changing the circuit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No bronze hull assembler recipe
6 participants