Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fluid lighting #53

Merged
merged 4 commits into from
Oct 1, 2023
Merged

fix fluid lighting #53

merged 4 commits into from
Oct 1, 2023

Conversation

firenoo
Copy link
Contributor

@firenoo firenoo commented Sep 30, 2023 •
edited by miozune
Loading

Close GTNewHorizons/GT-New-Horizons-Modpack#14146
Disable lighting before drawing the fluid since it messes up rendering quads
image

miozune
miozune approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@miozune miozune merged commit f3ccbf9 into master Oct 1, 2023
1 check passed
@miozune miozune deleted the fix/fluid_lighting branch October 1, 2023 02:28
@miozune miozune mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miozune miozune miozune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fluid brightness in GT machines changes when holding an item in hand
2 participants
@firenoo @miozune