Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Builder test update info #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mcgode
Copy link

@Mcgode Mcgode commented May 9, 2023

In test_builder, we use the following structure to pass graph info:

struct PrivateUpdateInfo
{
    uint32_t width;
    uint32_t height;
    RpsBool  bUseOffscreenRT;
    RpsBool  bUseMSAA;
};

However we were using rpsTypeInfoInitFromType(void*) to pass param type information to the graph. This resulted in the graph param size being set to 8 bytes (the size of a pointer on an x64 machine), while the actual data in 16 bytes long.
This meant that the struct data was only partially copied, and that the values of booleans fetched in the builder callback were undefined.

This PR fixes the issue by passing the correct type in the param information field.

@FlorianHerickAMD
Copy link
Collaborator

Thank you for reporting this. We will address this either as part of a small maintenance update or the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants