Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support builds with shapelib (as documented). #1268

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

tsteven4
Copy link
Collaborator

we document the ability to build without shapelib:

GPSBABEL_WITH_SHAPELIB:STRING=no|pkgconfig|included*|custom
  no: build without shapelib.  functionality will be limited.

This is supported in shapelib.cmake, but CMakeLists.txt defeats this functionality by always defining SHAPELIB_ENABLED.

@robertlipe
Copy link
Collaborator

There was a time I cared about requiring libs of many hundreds of bytes.

That time has past. Maybe we just say we require what we require and quit fretting over the combinations.

A one-line fix isn't exactly the breaking point. I'm just saying that in the future (the current) let's not worry much about this kind of thing. I'd rather have one build that works really well than six builds that support different subsets of $THINGS.

@tsteven4 tsteven4 merged commit 386f1ca into GPSBabel:master Apr 18, 2024
19 checks passed
@tsteven4 tsteven4 deleted the noshape branch April 18, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants