convert garmin_fs functions from char* -> QString #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlipe
approved these changes
Oct 30, 2023
| void | ||
| garmin_fs_xml_convert(const int base_tag, int tag, const QString& qstr, Waypoint* waypt) | ||
| bool | ||
| garmin_fs_convert_category(const QString& category_name, uint16_t* category) |
There was a problem hiding this comment.
Should we phase this stye of calling convention out in favor of returning an optional category ans then testing has_value() in the caller?
Not a blocker for this - I don't want to punish rearrangement...
There was a problem hiding this comment.
yes, https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-out-multi
or in this case as you point out an optional will do.
There was a problem hiding this comment.
thanks, but I'm moving on to bigger fish.
| // Is the name "Category" followed by a number? Use that number. | ||
| if (category_name.startsWith(u"Category ", Qt::CaseInsensitive)) { | ||
| bool ok; | ||
| int i = category_name.mid(9).toInt(&ok); |
There was a problem hiding this comment.
...toInt() would probably do that if it were written today.
Also, this could be toUint() and save one test below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also