[CHORE/#3] fake repo list json 파일명 상수화

GO-SOPT-ANDROID · Apr 22, 2023 · 7183439 · 7183439
1 parent 51c3e22
commit 7183439
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/src/main/java/org/android/go/sopt/data/source/RepoDataSource.kt b/app/src/main/java/org/android/go/sopt/data/source/RepoDataSource.kt
@@ -10,8 +10,12 @@ class RepoDataSource @Inject constructor(
     private val assetLoader: AssetLoader,
 ) {
     fun getRepoList(): Array<MockRepoDto> {
-        return assetLoader.getJsonString("fake_repo_list.json")?.let { jsonString ->
+        return assetLoader.getJsonString(FILE_FAKE_REPO_LIST)?.let { jsonString ->
             Json.decodeFromString<Array<MockRepoDto>>(jsonString)
         } ?: emptyArray()
     }
+
+    companion object {
+        private const val FILE_FAKE_REPO_LIST = "fake_repo_list.json"
+    }
 }
diff --git a/app/src/main/java/org/android/go/sopt/presentation/main/home/HomeViewModel.kt b/app/src/main/java/org/android/go/sopt/presentation/main/home/HomeViewModel.kt
@@ -40,8 +40,8 @@ class HomeViewModel @Inject constructor(
                     Timber.d("GET REPO LIST SUCCESS : $repoList")
                 }
                 .onFailure { t ->
-                    Timber.e("GET REPO LIST FAIL : ${t.message}")
                     _getRepoListState.value = Failure(null)
+                    Timber.e("GET REPO LIST FAIL : ${t.message}")
                 }
         }
     }