Fix naming of subtracks produced by "group by tag" operation (#4731)

GMOD · Dec 19, 2024 · 4d79a08 · 4d79a08
1 parent 4af106a
commit 4d79a08
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/plugins/alignments/src/LinearPileupDisplay/components/GroupByDialog.tsx b/plugins/alignments/src/LinearPileupDisplay/components/GroupByDialog.tsx
@@ -142,7 +142,7 @@ const GroupByTagDialog = observer(function (props: {
                   session.addTrackConf({
                     ...trackConf,
                     trackId: t1,
-                    name: `${trackConf.name} (-)`,
+                    name: `${trackConf.name} (${tag}:${tagValue})`,
                     displays: [
                       {
                         displayId: `${t1}-LinearAlignmentsDisplay`,

diff --git a/plugins/alignments/src/PileupRenderer/renderMismatches.ts b/plugins/alignments/src/PileupRenderer/renderMismatches.ts
@@ -118,11 +118,11 @@ export function renderMismatches({
     } else if (mismatch.type === 'insertion' && drawIndels) {
       const pos = leftPx + extraHorizontallyFlippedOffset
       const len = +mismatch.base || mismatch.length
-      const insW = Math.max(0, Math.min(1.2, 1 / bpPerPx))
+      const insW = Math.max(minSubfeatureWidth, Math.min(1.2, 1 / bpPerPx))
       if (len < 10) {
         fillRect(ctx, pos, topPx, insW, heightPx, canvasWidth, 'purple')
         if (1 / bpPerPx >= charWidth && heightPx >= heightLim) {
-          const l = pos - insW
+          const l = Math.round(pos - insW)
           fillRect(ctx, l, topPx, insW * 3, 1, canvasWidth)
           fillRect(ctx, l, topPx + heightPx - 1, insW * 3, 1, canvasWidth)
           ctx.fillText(`(${mismatch.base})`, pos + 3, topPx + heightPx)

diff --git a/...ts/jbrowse-web/src/tests/__image_snapshots__/breakpoint_split_view_snapshot.svg b/...ts/jbrowse-web/src/tests/__image_snapshots__/breakpoint_split_view_snapshot.svg
diff --git a/products/jbrowse-web/src/tests/__snapshots__/ExportSvgBreakpointSplitView.test.tsx.snap b/products/jbrowse-web/src/tests/__snapshots__/ExportSvgBreakpointSplitView.test.tsx.snap