Splitting data and helper operations into separate files and avoid unnecessary downloads #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d included check for existence of files
|
I think this can be closed, being superseeded..? |
jasperschroeder
deleted the
js/no_download_if_file_is_already_present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two major changes with this Pull Request:
Splitting data and helper operations into separate files
To avoid cluttering of runAnalysis file, I extracted the functions that take care of data operations and general utility functions into a data_utils and a utils file. (The data_utils file replaced/extended the previous input_utils file). Relates to what is mentioned in Issue 35
Check if requested file is already present
To avoid time-consuming save/write operations, I included a check if a file already exists so that a file does not need to be written again.
Other than that, I improved/modified existing code, where possible. I also had a look at the GUI_F3.ipynb notebook and made some improvements, where possible.