More informative error messages #3161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collection name in case of duplicate collection
AgilentGCMS
added
the
0 Diff
tclune
reviewed
Nov 6, 2024
tclune
reviewed
Nov 6, 2024
tclune
previously approved these changes
Nov 6, 2024
tclune
previously approved these changes
Nov 6, 2024
|
@AgilentGCMS Please add an entry in CHANGELOG.md in the top directory. |
|
Looks like something went very wrong with the CI. (Unrelated to your change.) Will discuss with @mathomp4 tomorrow. |
|
Those are weird errors... |
|
Okay. I think it was just an old circleci config. I merged in the latest develop and it's happy. @AgilentGCMS Can you pull and update the CHANGELOG with an entry? |
818Nawaf
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
base/MAPL_CFIO.F90, addedIamto a print statement so that when a read fails we know which routine failed.gridcomps/ExtData2G/ExtDataConfig.F90, print out the name of the duplicate collection that causes model to fail.