-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update LONG_NAME attributes to match M21C file specs; conservative regridding of (obs) PRECIP_FILE inputs #1032
base: develop
Are you sure you want to change the base?
update LONG_NAME attributes to match M21C file specs; conservative regridding of (obs) PRECIP_FILE inputs #1032
Conversation
…f _albedo -> _reflectivity] (GEOS_CatchGridComp.F90, GEOS_CatchCNCLM40GridComp.F90, GEOS_LandIceGridComp.F90, CatchmentRst.F90)
@biljanaorescanin, @sdrabenh: There's one more issue related to copying the M21C file specs changes into "develop". For M21C, we got NaNs in the all-surface runoff output because of a bug that was introduced with changes to the routing scheme (as currently used in the coupled model). The corresponding M21C PR is #969. However, the fix that we implemented for M21C is unlikely to work for "develop" because the M21C fix effectively disables the routing scheme (which is not needed for M21C). Note also that the relevant code block in "develop" is somewhat different from that of the "R21C" branch. Having said that, it's not clear to me that the bug still exists in "develop". So first we need to run the GCM for a day or so, using the branch from this PR, and output the "flx" collection from M21C (which includes the all-surface runoff). If this produces reasonable RUNOFFTOT values, no further action is needed. Somewhat more likely, though, this will produce NaNs for RUNOFFTOT. If that is the case, we need to find a fix for the RUNOFFTOT output that does not adversely impact the routing scheme. To find such a fix, we may need to go back to Atanas, who introduced the problematic change in the R21C tag. |
Here are Catch and Surf metadata diff summary: Comparing NC4 surf_import_checkpoint using nccmp... For history collections: Comparing tavg1_2d_flx_Nx-.20150414_2130z... Comparing tavg1_2d_lfo_Nx-.20150415_0030z... LND collection differences are too long to list here since most variable name changes are there. But all changes are in metadata + we now with branch have one more extra variable |
@sdrabenh: This PR is now ready for merging as far as the land group is concerned. We still need review and approval from @GEOS-ESM/landice-team, @GEOS-ESM/ocean-team, and @GEOS-ESM/seaice-team. Also, the (all-surface) RUNOFF output is indeed NaN, which requires fixing by @atrayano (see comment above date 7 Nov 2024 6:17pm EST). I think it would be best merge this PR as is (pending the aforementioned review and approvals) and start a new PR that addresses the NaNs in the (all-surface) RUNOFF output. |
The primary objective of the present PR is to bring the file specs changes from M21C into "develop". The corresponding M21C PR is #637 (merged on 8 Dec 2022).
Additionally, the present PR changes the "regrid_method" for the input (obs) precipitation from PRECIP_FILE in
GEOS_SurfaceGridComp.F90
to "conserve". This is of no consequence for FP-like systems that do not use observed precip inputs. The change was made with a view towards future reanalysis and S2S systems.No changes were made to GEOS_CatchCNCLM45GridComp.F90 because this CatchCN model version is scientifically obsolete and has been disabled. (Proper cleanup of the repo remains pending.)
In M21C, most LONG_NAME attributes for "albedo" were changed to "reflectivity". For consistency, I applied this change in a few more places where it was not applied in M21C (3790723, e31cda3).
Specific comments:
GEOS_SurfaceGridComp.F90
GEOSsaltwater_GridComp/*.F90
GEOS_SeaiceInterfaceGridComp.F90