-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2주차 - 김정호 #12
Merged
Merged
2주차 - 김정호 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
application.properties -> application.yml로 파일명 변경
- 메서드 이름은? - 덧셈 기능을 제공하는 메서드의 파라미터 개수는? - 메서드는 정적 메서드? 인스턴스 메서드? - 메서드를 제공하는 클래스명은?
모든 규칙을 충족하는 경우
PasswordStrengthMeter 작성 PasswordStrength 작성
아무 조건도 충족하지 못한 경우를 위해서 조건문 수정 및 반환문 순서 조정
가독성 개선을 위해 충족한 조건 개수 세는 코드 메서드로 분리
Closed
3 tasks
rladuswl
reviewed
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
머지하겠습니다~
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.