Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staker script interface #188

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Staker script interface #188

wants to merge 2 commits into from

Conversation

mrk-hub
Copy link
Contributor

@mrk-hub mrk-hub commented Nov 19, 2024

Updated IStaker.sol to match current Staker.sol
Updated staker.game7-testnet.md to ensure on-chain testing on testnet of Staker.sol and PositionMetadata.sol

Copy link

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • IStaker.sol: Primary modifications include refactoring function parameters for consistency and adding an 'administrator' field to the createPool function.

🔗 Commit Hash: 9825564

Copy link

octane-security-app-dev bot commented Nov 19, 2024

Overview

Vulnerabilities found: 4                                                                                
Severity breakdown: 4 Medium

Detailed findings

web3/contracts/faucet/TokenFaucet.sol

  • Review potential External Calls issue that is exposed in the claim function

web3/contracts/faucet/TokenSender.sol

  • Review potential External Calls issue that is exposed in the send function

web3/contracts/metronome/Metronome.sol

  • Review potential External Calls issue that is exposed in the _claim function

web3/contracts/staking/Staker.sol


🔗 Commit Hash: 9825564
🛡️ Octane Dashboard: All vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant