Improve logging perf (#1219)

* Remove association preloads from run verification func * Add new mlflow alembic version
G-Research · May 21, 2024 · 753a7e7 · 753a7e7
1 parent 1b18330
commit 753a7e7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/pkg/api/mlflow/dao/repositories/run.go b/pkg/api/mlflow/dao/repositories/run.go
@@ -86,12 +86,6 @@ func (r RunRepository) GetByNamespaceIDRunIDAndLifecycleStage(
 	run := models.Run{ID: runID}
 	if err := r.GetDB().WithContext(
 		ctx,
-	).Preload(
-		"LatestMetrics",
-	).Preload(
-		"Params",
-	).Preload(
-		"Tags",
 	).Joins(
 		"INNER JOIN experiments ON experiments.experiment_id = runs.experiment_id AND experiments.namespace_id = ?",
 		namespaceID,

diff --git a/pkg/database/migrate.go b/pkg/database/migrate.go
@@ -24,6 +24,7 @@ var supportedAlembicVersions = []string{
 	"7f2a7d5fae7d",
 	"2d6e25af4d3e",
 	"acf3f17fdcc7",
+	"867495a8f9d4",
 }
 
 // CheckAndMigrateDB makes database migration.
@@ -121,7 +122,7 @@ func CheckAndMigrateDB(migrate bool, db *gorm.DB) error {
 			}
 			fallthrough
 
-		case "97727af70f4d", "3500859a5d39", "7f2a7d5fae7d", "2d6e25af4d3e", "acf3f17fdcc7":
+		case "97727af70f4d", "3500859a5d39", "7f2a7d5fae7d", "2d6e25af4d3e", "acf3f17fdcc7", "867495a8f9d4":
 			// run the FML migrations generated by `make migrations-rebuild`
 			if err := generatedMigrations(db, schemaVersion.Version); err != nil {
 				return fmt.Errorf("error running generated migrations: %w", err)

diff --git a/tests/integration/golang/compatibility/mlflow_test.go b/tests/integration/golang/compatibility/mlflow_test.go
@@ -63,7 +63,7 @@ func (s *MLflowTestSuite) SetupSuite() {
 		S3EndpointURI:         helpers.GetS3EndpointUri(),
 		GSEndpointURI:         helpers.GetGSEndpointUri(),
 	})
-	s.Nil(err)
+	s.Require().Nil(err)
 	s.server = srv
 
 	s.aimClient = func() *helpers.HttpClient {