-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metrics filtering for Conditional Grouping #86
Add Metrics filtering for Conditional Grouping #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch Fabio! I'll take a look at it |
I managed to fix it by adding the context to the attributes to evaluate. I also double checked that there aren't any important attributes that we might want to put in there in the future. The issue with the duplicated entries was fixed by checking for unique values. There is currently an issue with the metrics displaying as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good -- is there a ticket/issue for the todo items?
Just added one! G-Research/fasttrackml#1295 |
* Add conditionalGroupingOptions prop * Add metrics support to ChartPopover (Metrics app) * Add condtionalGroupingOptions state * Add TODO for Params and Scatters * Fix context conditional grouping and repeated metrics --------- Co-authored-by: fabiovincenzi <[email protected]>
This PR adds Metrics to the list of fields we can filter conditionally for splitting charts. Because each run may have a different value for each metric, only the last value is considered when evaluating (as per Marin's suggestion).
Note that the conditional filtering is only available on the Metrics app at the moment.
Changelog
conditionalGroupingOptions
)